New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquid Exception comparison of Array with Array failed #406
Comments
@patrik-u if you'd like us to look at this, could you create a small test repository that exhibits the issue, and post a link to it? BTW, you refer to |
That was a typo, the folder is indeed |
Added a repository here: https://github.com/patrik-u/just-the-docs-issue It doesn't render exactly as the github pages site (not sure why). You can see the error when running and it goes away if you rename the files in _posts/ or remove the folder. |
Thanks, that helped. I don't understand why the sorting fails, but as a workaround, try |
Thanks that solved it for me. |
I'll submit a PR with that update to The Jekyll failure was due to
Jekyll treats The simplest way to make your repository work (without the fix to |
Thanks, that worked. |
The reported Liquid exception is due to sorting an array that contains mixed types of values. In this case, the Jekyll/Liquid error reports can be confusing, and the theme code should try to ensure that they never arise. |
Pages with `nav_exclude: true` were included when sorting on `title` or `nav_order`. That could cause build failures when the type of value of the field differs from that on other pages, as reported in just-the-docs#406. Pages with `nav_exclude: true` or no `title` are never displayed in the navigation, so removing them from `pages_list` cannot break existing sites. This change also allows the removal of some tests in the code. (The indentation of the code should now be adjusted, but that has been deferred, to restrict the size of the diff for review.) For testing, the title of `404.html` has been changed to the number `404`, the page `docs/untitled-test.md` has been added, and `nav_sort_order` has been set to `case_sensitive`. Those updates give build failures with the current version of `_includes/nav.html`, but not after the suggested changes. It will still be possible for build failures to occur due to sorting fields of *non-excluded* pages with differing types of values (e.g., `nav_order`a mixture of numbers and strings). To make the code completely safe will require relatively complicated changes,.
I have a github pages site which suddenly started generating generic errors whenever I committed changes (been a while since i committed, last was in may):
Wasn't very helpful, so contacted github support and they saw the following error in their logs:
Not very helpful so I after some trial and error getting the site to compile locally I managed to replicate the error. After more trial and error I found that if files under _post/ starts with numbers it caused the error to happen. Removing them and the error goes away. Heureka! So I did the changes committed it to my github pages and...
Page build failed.
So I can no longer reproduce the error locally, and build fails on github pages. I've contacted the support and maybe there is a different error this time.
The text was updated successfully, but these errors were encountered: