Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS charset #45

Closed
egmontkob opened this issue Nov 30, 2018 · 3 comments
Closed

Missing CSS charset #45

egmontkob opened this issue Nov 30, 2018 · 3 comments

Comments

@egmontkob
Copy link

Hi,

First of all, thanks for this lovely theme!

I uploaded a site based on this theme to GitLab, and received the following error:

$ bundle exec jekyll build -d public
[...]
      Generating... 
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/dark-mode-preview.scss':
                    Invalid US-ASCII character "\xE2" on line 60
jekyll 3.8.5 | Error:  Invalid US-ASCII character "\xE2" on line 60
ERROR: Job failed: exit code 1

The error message is misleading, the said file doesn't even contain 60 lines. Instead, the culprit is _sass/content.scss which, on line 60, contains a Unicode "Bullet" character whose first byte is indeed 0xE2.

Adding

@charset "UTF-8";

to the top of _sass/content.scss fixes this issue.

I'm new to all this Jekyll and stuff business, I have no idea what difference in configuration makes it apparently work for you on GitHub and also made it work for me locally, but causes failiure on GitLab. Anyway, if you agree that this is a proper fix, could you please apply it? Thanks!

@pmarsceill
Copy link
Collaborator

@egmontkob Do you want to open a PR for this?

@egmontkob
Copy link
Author

If you don't mind, I'd rather not. Just submit this one-liner on your behalf – if you agree with this fix –, that's absolutely fine. (Seriously.) Thanks!

(Make sure to copy verbatim, e.g. single quotes didn't work for me.)

@flut1
Copy link
Contributor

flut1 commented Dec 12, 2018

@pmarsceill I needed this in my project so I took the liberty to fork and create the PR. Fix seems to work great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants