Fix incorrect padding property value pair in search.scss
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR corrects the change to `/_sass/search.scss` made in 551398f. This change tried to set the `padding-**top**` property to **two** values rather than set the `padding` property to these values (to represent the vertical and horizontal padding values). I just reviewed 551398f and believe that this should be the other half of the fix proposed by #1104.
mattxwang
approved these changes
Jan 9, 2023
2 tasks
danilocurvelo
pushed a commit
to danilocurvelo/imd0030-20241
that referenced
this pull request
Feb 26, 2024
Awaiting upstream merge for just-the-docs/just-the-docs#1123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just reviewed 551398f and believe that this should be the other half of the fix proposed by #1104.
This PR corrects the change to
/_sass/search.scssmade in 551398f. This change tried to set thepadding-topproperty to two values rather than set thepaddingproperty to these values (to represent the vertical and horizontal padding values).