Fix Windows emoji font fallback #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Thank you for contributing a PR @flanakin! This LGTM.
As an aside, it seems like system font stack defaults these days include a few more fonts.
- CSS Tricks additionally includes
"Apple Color Emoji"and"Segoe UI Symbol" - a similar website also includes some more pre-installed fonts on most OSes:
avenir,avenir next,cantarell,ubuntu,noto
The former is probably a trivial inclusion, while the latter actually does change the look of the site (i.e. it'd take precedence over Arial). I'll ponder this and deal with this in another PR.
Thanks again @flanakin for investigating and submitting a PR!
mattxwang
changed the title
mattxwang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the "Segoe UI Emoji" font as a fallback to cover all emojis on Windows.
Closes #1329