-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow unlimited multi-level navigation #1431
base: main
Are you sure you want to change the base?
Commits on Feb 24, 2024
-
Allow unlimited multi-level navigation
This PR is intended to supersede just-the-docs#462. The only user-level difference from just-the-docs#462 is that disambiguation of parent pages has to use either `grand_parent` or `ancestor` titles: the somewhat unnatural `section_id` and `in_section` fields are not supported. The implementation has been significantly simplified by the changes introduced in v0.7.0 of the theme. This initial draft has not yet been rigorously tested nor profiled.
Configuration menu - View commit details
-
Copy full SHA for c45f622 - Browse repository at this point
Copy the full SHA c45f622View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4919cb1 - Browse repository at this point
Copy the full SHA 4919cb1View commit details -
Unclear to me why adding this gem causes CI failures.
Configuration menu - View commit details
-
Copy full SHA for f9db7fd - Browse repository at this point
Copy the full SHA f9db7fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b99d02 - Browse repository at this point
Copy the full SHA 7b99d02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a02812 - Browse repository at this point
Copy the full SHA 1a02812View commit details
Commits on Feb 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e1fce3 - Browse repository at this point
Copy the full SHA 9e1fce3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c7d2d1 - Browse repository at this point
Copy the full SHA 5c7d2d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dc6153 - Browse repository at this point
Copy the full SHA 8dc6153View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47a5c79 - Browse repository at this point
Copy the full SHA 47a5c79View commit details -
A page should not have a parent or ancestor with the same title. If it does, the location of the repeated link is marked by ∞, to facilitate debugging the navigation (and an unbounded loop leading to a build exception is avoided). It might be preferable to emit a warning in the Jekyll build log, but that doesn't appear to be supported by Liquid/Jekyll tags.
Configuration menu - View commit details
-
Copy full SHA for 655d11a - Browse repository at this point
Copy the full SHA 655d11aView commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 25e412e - Browse repository at this point
Copy the full SHA 25e412eView commit details -
In Jekyll 3, Liquid’s binary `and` and `or` operations cannot be used in the `where_exp` filter...
Configuration menu - View commit details
-
Copy full SHA for 6cdc654 - Browse repository at this point
Copy the full SHA 6cdc654View commit details
Commits on Feb 27, 2024
-
Avoid diffs from sites built with v0.8.0
Configuration menu - View commit details
-
Copy full SHA for 5da5c87 - Browse repository at this point
Copy the full SHA 5da5c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4f762a - Browse repository at this point
Copy the full SHA c4f762aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eecba73 - Browse repository at this point
Copy the full SHA eecba73View commit details -
Configuration menu - View commit details
-
Copy full SHA for f50c207 - Browse repository at this point
Copy the full SHA f50c207View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ee3af5 - Browse repository at this point
Copy the full SHA 2ee3af5View commit details -
This is for backwards compatibility with sites that use `has_children: false` to suppress navigation links to child pages.
Configuration menu - View commit details
-
Copy full SHA for a649a47 - Browse repository at this point
Copy the full SHA a649a47View commit details
Commits on Mar 4, 2024
-
Fix breadcrumbs for excluded pages
Takes account of ancestors. To test, add to 404.html front matter: ```yaml parent: T grand_parent: S ancestor: Y ``` Then check that 404.html has the correct breadcrumbs.
Configuration menu - View commit details
-
Copy full SHA for c31d6e1 - Browse repository at this point
Copy the full SHA c31d6e1View commit details
Commits on Mar 9, 2024
-
Add nav_error_report warning in main navigation
When activated by `nav_error_report: true` in `_config.yml`, displays warnings about pages with the same title as their parent page or an ancestral page.
Configuration menu - View commit details
-
Copy full SHA for c832248 - Browse repository at this point
Copy the full SHA c832248View commit details -
Fix breadcrumbs for excluded pages
The breadcrumbs for excluded pages were incorrect in previous commits, due to interference between assignments in recursive inclusions of ancestry.html.
Configuration menu - View commit details
-
Copy full SHA for 9be113b - Browse repository at this point
Copy the full SHA 9be113bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c825c8b - Browse repository at this point
Copy the full SHA c825c8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b6d919 - Browse repository at this point
Copy the full SHA 2b6d919View commit details
Commits on Mar 11, 2024
-
It appears that: - `nav_levels[1] == nil` holds only when not `site_nav contains nav_list_link`; - `nav_levels[2] == nil and nav_levels[3]` never holds.
Configuration menu - View commit details
-
Copy full SHA for 6061496 - Browse repository at this point
Copy the full SHA 6061496View commit details
Commits on Mar 12, 2024
-
* Generate rules for any number of levels * Improve layout of generated rules * Improve layout of Liquid tags
Configuration menu - View commit details
-
Copy full SHA for ce52b12 - Browse repository at this point
Copy the full SHA ce52b12View commit details
Commits on Mar 13, 2024
-
Optimise breadcrumbs for excluded pages
Revert to the original code for nav/ancestry. The previous draft increased the build time 5x with Jekyll 3 for a site with about 550 pages, of which 150 are excluded from the main navigation.
Configuration menu - View commit details
-
Copy full SHA for 53b47c3 - Browse repository at this point
Copy the full SHA 53b47c3View commit details
Commits on Mar 15, 2024
-
Cache site-nav with links to all pages
The extra cached site-nav is used for determining breadcrumbs and children navigation, which may involve pages that are excluded from the main navigation. The inefficient code previously used for excluded pages is now redundant, and to be removed in a subsequent commit.
Configuration menu - View commit details
-
Copy full SHA for d3e5290 - Browse repository at this point
Copy the full SHA d3e5290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7deaf18 - Browse repository at this point
Copy the full SHA 7deaf18View commit details -
Replace code for determining children by inclusion of components/nav/children.html Profiling locally, this doesn't appear to lose efficiency.
Configuration menu - View commit details
-
Copy full SHA for f454aee - Browse repository at this point
Copy the full SHA f454aeeView commit details
Commits on Mar 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 00b182d - Browse repository at this point
Copy the full SHA 00b182dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2230c - Browse repository at this point
Copy the full SHA bf2230cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c744937 - Browse repository at this point
Copy the full SHA c744937View commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 61a97d0 - Browse repository at this point
Copy the full SHA 61a97d0View commit details