Fix duplicate entries in nav.html and default.html

[KasparEtter]

This commit resolves #207.

[pmarsceill]

@pdmosses could you take a look at this? Does this make sense to you?

[pdmosses]

@pmarsceill I'll take a look and let you know

[pdmosses]

@pmarsceill I added test files (locally) for the example shown in #207 and it gives the correct navigation hierarchy, using the grand_parent titles to avoid duplicated displays.

In fact I'd experienced the bug in a previous project of my own, but circumvented it by making all the titles unique.

Note that the recursive navigation proposal #192 doesn't involve grand_parent settings, so duplicate ancestor titles might be more difficult to support with that.

[pdmosses]

@pmarsceill oops, the entries of the automatic TOCs for children are missing! For example, select UI Components. I'll take a look at the code in default.html.

[pdmosses]

@pmarsceill I've found what I think is the bug in default.html. It refers to children_list, which is assigned in nav.html. Copying the following code from nav.html to default.html fixes it:

          {%- assign ordered_pages_list = site.html_pages | where_exp:"item", "item.nav_order != nil" -%}
          {%- assign unordered_pages_list = site.html_pages | where_exp:"item", "item.nav_order == nil" -%}
          {%- if site.nav_sort == 'case_sensitive' -%}
            {%- assign sorted_ordered_pages_list = ordered_pages_list | sort:"nav_order" -%}
            {%- assign sorted_unordered_pages_list = unordered_pages_list | sort:"title" -%}
          {%- else -%}
            {%- assign sorted_ordered_pages_list = ordered_pages_list | sort_natural:"nav_order" -%}
            {%- assign sorted_unordered_pages_list = unordered_pages_list | sort_natural:"title" -%}
          {%- endif -%}
          {%- assign pages_list = sorted_ordered_pages_list | concat: sorted_unordered_pages_list -%}
          {%- assign children_list = pages_list | where: "parent", node.title -%}

Should I commit that change to KasparEtter's fork?

[pdmosses]

@pmarsceill in fact only the last line above, assigning to children_list, needs to be added in default.html: the value of pages_list in nav.html is subsequently available in default.html.

[pmarsceill]

@pdmosses is this good to merge into 0.2.9 now?

[pdmosses]

@pmarsceill looking at it now, I noticed that the list of grandchildren in the nav uses site.html_pages, which is unsorted.

I have a local test directory with grandchildren; I'll expand it to check whether I can make it get the order wrong, and let you know.

[pdmosses]

My suspicion was justified: in my local test with grandchildren, the nav order was not respected. The update I committed appears to have corrected that.

[pdmosses]

@pmarsceill good to merge into 0.2.9 now, I believe.