Provide ability to skip to main content #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are these changes being introduced: * The current tab order requires keyboard or screenreader users to tab though all of the navigation links before they get to the main content of the page Relevant ticket(s): * Discussed as part of larger WCAG ticket just-the-docs#566 How does this address that need: * Introduces an off screen link as the first element in the tab order that will display when it has focus but remain off screen for users not using tab to navigate the document. * Introduces a new scss file with the required style elements and uses colors variables to ensure both light and dark mode are respected. Background information on this technique: - https://www.w3.org/TR/WCAG20-TECHS/G1.html - https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/mouse-and-keyboard-events/skip-to-main-content/
|
Leaving a comment to note that I haven't forgotten about this PR - will get to reviewing this in-depth when I have a chance. On first glance, it looks good! |
mattxwang
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Getting back to this now - thanks for your patience @JPrevost. I also have no constructive feedback here, appreciate you taking the time to implement this PR + adding the relevant links!
I manually tested this on the latest Chrome / Firefox and this works as expected. Great job as well in making this work with the dark theme. Good to merge!
|
Changelog:
Given the importance of your changes, going to cut a new release candidate today :) |
kevinlin1
added a commit
to kevinlin1/just-the-class
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
though all of the navigation links before they get to the main content
of the page
Relevant ticket(s):
How does this address that need:
that will display when it has focus but remain off screen for users
not using tab to navigate the document.
colors variables to ensure both light and dark mode are respected.
Background information on this technique: