This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Fix #257 #258
Merged
Fix #257 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Explicitly distinguish between replacing with `nil` and not replacing at all. I'm also simplifying the code by making all the branches more explicit. This is a little longer, but makes all the clauses obvious. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
|
Hmm, there's a failure on 24.5. I don't really understand why. |
|
Thanks. I'm not worried about the 24.5 failure. I'd like to overhaul this replacement stuff anyway. I just don't have any free time right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly distinguish between replacing with
niland not replacing atall.
I'm also simplifying the code by making all the branches more explicit.
This is a little longer, but makes all the clauses obvious.