Add preliminary support for menu-items #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify which-key--get-keymap-bindings to be useful in which-key--get-current-bindings and use it there. We no longer parse the output of describe-buffer-bindings.
justbur
force-pushed
the
feature/menu-item-support
branch
from
722d018
to
c28efe6
Compare
Closed
This was referenced Jun 19, 2021
|
Thanks much for this @justbur! Just to confirm that with my initial tests using
|
Specifically, restore ability to compute remaps and ignore certsain commnads.
|
@bdarcus The RET issue you mentioned is a embark issue. |
The ?? entry is no longer necessary.
Prefix is no longer needed because we're using full key sequences now
minad
added a commit
to minad/consult
that referenced
this pull request
Jun 20, 2021
Use menu items instead, which are now supported by which-key. See justbur/emacs-which-key#308
|
I merged support for menu-items using a different approach in another branch |
minad
added a commit
to minad/consult
that referenced
this pull request
Jun 21, 2021
Use menu items instead, which are now supported by which-key. See justbur/emacs-which-key#308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not extensively tested and any help along these lines would be appreciated.