Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix EvilPortal for board setups without SD #483

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tracedgod
Copy link
Contributor

Adds a check for the HAS_SD definition to the setHtml & setAP functions respectively.

Without these changes, compilation fails due to the configuration not having an sd_obj reference.

Looks to be similar / identical to #479, minus a new board configuration being added in that PR.

adds a check for the HAS_SD definition to the setHtml & setAP functions respectively.
@tracedgod tracedgod changed the title fix EvilPortal with board setups without SD fix EvilPortal for board setups without SD Feb 12, 2024
@S-Ali-Zaidi
Copy link

Tried this and it fixed he issue I was having. Looks good to me!

@rgtiom
Copy link

rgtiom commented Feb 22, 2024

looks good to me. Fixed the issue. (Lilygo T-Beam)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants