Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolby Vision bug #798

Closed
Hellboy00000 opened this issue Oct 24, 2023 · 4 comments
Closed

Dolby Vision bug #798

Hellboy00000 opened this issue Oct 24, 2023 · 4 comments

Comments

@Hellboy00000
Copy link

Dolby Vision bug in last version "2023-10-21-01-50-32"

Original movie
DV-1-original

Good tsMuxer 2023-09-30-01-50-24
DV-3-2023-09-30-01-50-24

Bad tsMuxer 2023-10-21-01-50-32
DV-2-2023-10-21-01-50-32

I think the bug was introduced here:
#781

I don't understand the use of "Dolby Vision MKV to BD" because those MKV are cropped and when they are used with tsMuxer the picture looks stretch. So you need to encode an encoded video to add the black bars and that make the video looks worse.

jcdr428 added a commit that referenced this issue Oct 24, 2023
@DreckSoft
Copy link
Contributor

Of course you can only mux them to BD of they uncropped. No you do not need to reencode anything. Yes, you will lose DV but the result plays fine as HDR10.

Of course the patch was not supposed to break anything. The second stream should be recognized as DV_EL but it isn't.

Then I don't know how to patch it so both cases create a correct result.

@Hellboy00000
Copy link
Author

I always thought you need to encode again to add black bars. How you add the black bars without encoding?

@DreckSoft
Copy link
Contributor

Why should I add black bars to a 2160p file? That does not make any sense.

@Hellboy00000
Copy link
Author

Hellboy00000 commented Oct 25, 2023

I mean for files that are cropped. How you add the black bars without encoding?

Edit: Latest version work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants