Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BD V3 option to Blu-ray tab #120

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

jcdr428
Copy link
Collaborator

@jcdr428 jcdr428 commented Jan 8, 2020

BD version is automatically switched to V3 when HEVC stream is detected.
In case the user wants to force the V3 format for AVC, he will be able to do it via the V3 option in the Blu-ray tab.

Version is automatically switched to V3 when HEVC is detected.
In case the user wants to force the V3 format for AVC, he will be able to do it via the V3 option in the Blu-ray tab.
@jcdr428
Copy link
Collaborator Author

jcdr428 commented Jan 8, 2020

@xavery @justdan96 I don't have Qt5 installed so I haven't verified how the V3 checkbox appears in the GUI. Could you please test this branch before merging ?

@justdan96
Copy link
Owner

I'll try to test this out

Copy link
Owner

@justdan96 justdan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs 2 amendments, then looks ready for merge.

tsMuxerGUI/tsmuxerwindow.cpp Outdated Show resolved Hide resolved
tsMuxerGUI/tsmuxerwindow.ui Show resolved Hide resolved
@justdan96 justdan96 added the enhancement New feature or request label Jan 8, 2020
@justdan96
Copy link
Owner

Cool, looks ready now.

@justdan96 justdan96 merged commit b55b4df into justdan96:master Jan 8, 2020
@jcdr428 jcdr428 deleted the Move_V3_Option_to_Bluray_Tab branch January 9, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants