Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 – Updated Menulog colour palette (and the way it can be imported) #22

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

ashleynolan
Copy link
Contributor

Changed

  • Menulog theming updated (breaking change).
    The Menulog colours are now specified as a mixin that is called as part of individual modules if the $theme variable is set to 'ml'. This is so that each project importing fozzie modules only has to specify the theme variable once and each module will take care of it's own colour/variable overrides.
  • Menulog Colour Scheme has been updated in line with the global UI palette provided by AU design team.

UI Review Checks

  • This PR has been checked with regard to our brand guidelines
  • UI Documentation will be created once Menulog theming has been done (separate task)
  • This code has been checked with regard to our accessibility standards
    • The colours added/changed have been colour contrast tested [link]

@ashleynolan ashleynolan requested review from a team September 7, 2018 14:34
@@ -1,90 +1,43 @@
// =================================
// Menulog Color palette
// Menulog Color Scheme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this file be a partial now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean, can it be in a folder called partials?

I could put it in a folder called themes, as that's kinda what it is I guess?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was more of a question really; as the filename doesn't start with an underscore it implies, to me, that this file would be used generate a separate CSS file. Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok – makes sense. Yeh, should be able to be a file partial now – will update now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated that now 👍

@ashleynolan ashleynolan changed the title v2.0.0 – Updated Menulog colour palette (and the way it can be imported) –- DO NOT MERGE YET -- v2.0.0 – Updated Menulog colour palette (and the way it can be imported) Sep 10, 2018
Copy link
Contributor

@bulutcy bulutcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested yet, but LGTM

@ashleynolan
Copy link
Contributor Author

@bulutcy This will be integrated automatically with v1 of Fozzie (which is on it's way), but if you need help integrating before then just give me a shout

@ashleynolan ashleynolan merged commit c06c964 into master Sep 10, 2018
@ashleynolan ashleynolan deleted the v2.0.0 branch September 10, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants