-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0 – Updated Menulog colour palette (and the way it can be imported) #22
Conversation
0fa854e
to
a2d2a1f
Compare
src/scss/menulog.scss
Outdated
@@ -1,90 +1,43 @@ | |||
// ================================= | |||
// Menulog Color palette | |||
// Menulog Color Scheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be a partial now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean, can it be in a folder called partials?
I could put it in a folder called themes, as that's kinda what it is I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was more of a question really; as the filename doesn't start with an underscore it implies, to me, that this file would be used generate a separate CSS file. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok – makes sense. Yeh, should be able to be a file partial now – will update now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated that now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not tested yet, but LGTM
@bulutcy This will be integrated automatically with v1 of Fozzie (which is on it's way), but if you need help integrating before then just give me a shout |
Changed
The Menulog colours are now specified as a mixin that is called as part of individual modules if the $theme variable is set to 'ml'. This is so that each project importing fozzie modules only has to specify the theme variable once and each module will take care of it's own colour/variable overrides.
UI Review Checks