Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation time and completion message to log messages #1026

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

gkinsman
Copy link
Contributor

@gkinsman gkinsman commented Jun 15, 2022

We keep track of operation durations via LogOperation , but we don't add the duration to the log message currently.

This PR adds the duration and completion message so the log is now: Starting bus finished in 603ms instead of Starting bus

@gkinsman gkinsman requested a review from a team as a code owner June 15, 2022 12:48
@gkinsman gkinsman changed the title Add operation time to log messages Add operation time and completion message to log messages Jun 15, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1026 (2082372) into main (76f1550) will increase coverage by 0.09%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   84.83%   84.92%   +0.09%     
==========================================
  Files         135      135              
  Lines        3290     3291       +1     
==========================================
+ Hits         2791     2795       +4     
+ Misses        499      496       -3     
Flag Coverage Δ
linux 84.68% <50.00%> (+0.12%) ⬆️
macos 51.77% <50.00%> (+0.04%) ⬆️
windows 51.74% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/JustSaying/Messaging/Monitoring/LogOperation.cs 62.50% <50.00%> (+1.63%) ⬆️
...ng/Middleware/ExactlyOnce/ExactlyOnceMiddleware.cs 77.77% <0.00%> (-14.82%) ⬇️
...ools/MessageHandling/Dispatch/MessageDispatcher.cs 98.18% <0.00%> (+12.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f1550...2082372. Read the comment docs.

@gkinsman gkinsman merged commit 63a5976 into justeattakeaway:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants