Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Native AOT #1348

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,10 @@
<None Include="$(MSBuildThisFileDirectory)$(PackageIcon)" Pack="True" PackagePath="" />
<None Include="$(MSBuildThisFileDirectory)$(PackageReadmeFile)" Pack="True" PackagePath="" />
</ItemGroup>
<ItemGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)','net8.0'))">
<Using Include="System.Diagnostics.CodeAnalysis" />
</ItemGroup>
<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)','net8.0'))">
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
cfg.SerializerOptions.TypeInfoResolverChain.Insert(0, ApplicationJsonContext.Default);
});

builder.Services.Configure<JsonSerializerOptions>(cfg =>
builder.Services.Configure<JustSayingJsonSerializerOptions>(cfg =>
{
cfg.TypeInfoResolverChain.Insert(0, ApplicationJsonContext.Default);
cfg.SerializerOptions.TypeInfoResolverChain.Insert(0, ApplicationJsonContext.Default);
});

builder.Services.AddJustSaying(config =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public static IServiceCollection AddJustSaying(this IServiceCollection services,
services.TryAddSingleton<IMessageContextReader>(serviceProvider => serviceProvider.GetRequiredService<MessageContextAccessor>());

#if NET8_0_OR_GREATER
services.TryAddSingleton<IMessageSerializationFactory>(sp => new TypedSystemTextJsonSerializationFactory(sp.GetRequiredService<IOptions<JsonSerializerOptions>>().Value));
services.TryAddSingleton<IMessageSerializationFactory>(sp => new TypedSystemTextJsonSerializationFactory(sp.GetRequiredService<IOptions<JustSayingJsonSerializerOptions>>().Value));
#else
services.TryAddSingleton<IMessageSerializationFactory, NewtonsoftSerializationFactory>();
#endif
Expand Down
74 changes: 38 additions & 36 deletions src/JustSaying/AwsTools/MessageHandling/SnsPolicyBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,42 +13,44 @@ internal static string BuildPolicyJson(SnsPolicyDetails policyDetails)
throw new ArgumentException("Must be a valid ARN.", nameof(policyDetails));
}
var accountId = arn.AccountId;
return $@"{{
""Version"" : ""2012-10-17"",
""Statement"" : [
{{
""Sid"" : ""{Guid.NewGuid().ToString().Replace("-", "")}"",
""Effect"" : ""Allow"",
""Principal"" : {{
""AWS"" : ""*""
}},
""Action"" : [
""sns:GetTopicAttributes"",
""sns:SetTopicAttributes"",
""sns:AddPermission"",
""sns:RemovePermission"",
""sns:DeleteTopic"",
""sns:Subscribe"",
""sns:Publish""
],
""Resource"" : ""{policyDetails.SourceArn}"",
""Condition"" : {{
""StringEquals"" : {{
""AWS:SourceOwner"" : ""{accountId}""
}}
}}
}},
{{
""Sid"" : ""{Guid.NewGuid().ToString().Replace("-", "")}"",
""Effect"" : ""Allow"",
""Principal"" : {{
""AWS"" : {SerializeAccountIds(policyDetails.AccountIds)}
}},
""Action"" : ""sns:Subscribe"",
""Resource"" : ""{policyDetails.SourceArn}""
}}
]
}}";
return $$"""
{
"Version" : "2012-10-17",
"Statement" : [
{
"Sid" : "{{Guid.NewGuid().ToString().Replace("-", "")}}",
"Effect" : "Allow",
"Principal" : {
"AWS" : "*"
},
"Action" : [
"sns:GetTopicAttributes",
"sns:SetTopicAttributes",
"sns:AddPermission",
"sns:RemovePermission",
"sns:DeleteTopic",
"sns:Subscribe",
"sns:Publish"
],
"Resource" : "{{policyDetails.SourceArn}}",
"Condition" : {
"StringEquals" : {
"AWS:SourceOwner" : "{{accountId}}"
}
}
},
{
"Sid" : "{{Guid.NewGuid().ToString().Replace("-", "")}}",
"Effect" : "Allow",
"Principal" : {
"AWS" : {{SerializeAccountIds(policyDetails.AccountIds)}}
},
"Action" : "sns:Subscribe",
"Resource" : "{{policyDetails.SourceArn}}"
}
]
}
""";
}

private static string SerializeAccountIds(IReadOnlyCollection<string> accountIds)
Expand Down
6 changes: 0 additions & 6 deletions src/JustSaying/JustSaying.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,4 @@
<ItemGroup>
<Using Remove="System.Net.Http" />
</ItemGroup>
<ItemGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)','net8.0'))">
<Using Include="System.Diagnostics.CodeAnalysis" />
</ItemGroup>
<PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)','net8.0'))">
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#if NET8_0_OR_GREATER
using System.Text.Json;

namespace JustSaying.Messaging.MessageSerialization;

public class JustSayingJsonSerializerOptions
{
public JsonSerializerOptions SerializerOptions { get; } = new();
martincostello marked this conversation as resolved.
Show resolved Hide resolved
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,7 @@ public SystemTextJsonSerializer()
/// <param name="options">The optional <see cref="JsonSerializerOptions"/> to use.</param>
public SystemTextJsonSerializer(JsonSerializerOptions options)
{
if (options == null)
{
options = new JsonSerializerOptions
{
#if NET8_0_OR_GREATER
DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull,
#else
IgnoreNullValues = true,
#endif
};

options.Converters.Add(new JsonStringEnumConverter());
}

_options = options;
_options = options ?? DefaultJsonSerializerOptions;
}

/// <inheritdoc />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
#if NET8_0_OR_GREATER
using System.Text.Json;
using JustSaying.Models;

namespace JustSaying.Messaging.MessageSerialization;

public class TypedSystemTextJsonSerializationFactory(JsonSerializerOptions options) : IMessageSerializationFactory
public class TypedSystemTextJsonSerializationFactory(JustSayingJsonSerializerOptions options) : IMessageSerializationFactory
{
public IMessageSerializer GetSerializer<T>() where T : Message => new SystemTextJsonSerializer<T>(options);
public IMessageSerializer GetSerializer<T>() where T : Message => new SystemTextJsonSerializer<T>(options.SerializerOptions);
}
#endif
5 changes: 4 additions & 1 deletion src/JustSaying/PublicAPI/net8.0/PublicAPI.Unshipped.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
JustSaying.Messaging.MessageSerialization.JustSayingJsonSerializerOptions
JustSaying.Messaging.MessageSerialization.JustSayingJsonSerializerOptions.JustSayingJsonSerializerOptions() -> void
JustSaying.Messaging.MessageSerialization.JustSayingJsonSerializerOptions.SerializerOptions.get -> System.Text.Json.JsonSerializerOptions
JustSaying.Messaging.MessageSerialization.SystemTextJsonSerializer<T>
JustSaying.Messaging.MessageSerialization.SystemTextJsonSerializer<T>.Deserialize(string message, System.Type type) -> JustSaying.Models.Message
JustSaying.Messaging.MessageSerialization.SystemTextJsonSerializer<T>.GetMessageAttributes(string message) -> JustSaying.Messaging.MessageHandling.MessageAttributes
Expand All @@ -7,4 +10,4 @@ JustSaying.Messaging.MessageSerialization.SystemTextJsonSerializer<T>.SystemText
JustSaying.Messaging.MessageSerialization.SystemTextJsonSerializer<T>.SystemTextJsonSerializer(System.Text.Json.JsonSerializerOptions options) -> void
JustSaying.Messaging.MessageSerialization.TypedSystemTextJsonSerializationFactory
JustSaying.Messaging.MessageSerialization.TypedSystemTextJsonSerializationFactory.GetSerializer<T>() -> JustSaying.Messaging.MessageSerialization.IMessageSerializer
JustSaying.Messaging.MessageSerialization.TypedSystemTextJsonSerializationFactory.TypedSystemTextJsonSerializationFactory(System.Text.Json.JsonSerializerOptions options) -> void
JustSaying.Messaging.MessageSerialization.TypedSystemTextJsonSerializationFactory.TypedSystemTextJsonSerializationFactory(JustSaying.Messaging.MessageSerialization.JustSayingJsonSerializerOptions options) -> void
Loading