Add SNS request Id to log message when message is published

[maurofranchi]

We are currently experiencing some SNS issues in production and AWS always ask us to provide them with some SNS Request Ids related to the problematic publish operations. Unfortunately JustSaying is not returning it.

This PR is to simply add the returned request Id (if present) to the message logged when a message is published.
I know V6 is currently in maintenance mode but this could help us investigate a bit better on any issue we might have on AWS.

[slang25]

If the publish is fails with an exception then today you can use HandleException to then log the request id. @josephwoodward added this functionality for this reason (AWS wanted request ids to be able to provide support)
#350

[martincostello]

Ah - for some reason I thought that capability only existed in v7. In that case, we can just use that and not bother changing the logs.

[martincostello]

Just checked the tags of the merge commit (ef8334a) and it's in all the v6 releases.

[maurofranchi]

If the publish is fails with an exception then today you can use HandleException to then log the request id. @josephwoodward added this functionality for this reason (AWS wanted request ids to be able to provide support)
#350

I saw the messageId is returned, but lately AWS started asking for RequestId which is not currently added to the MessageResponse object from that PR you linked. Do you want me to add it to that object?

[maurofranchi]

I saw the messageId is returned, but lately AWS started asking for RequestId which is not currently added to the MessageResponse object from that PR you linked. Do you want me to add it to that object?

Also I forgot to say that in our case the request doesn't fail, so we would not have the handleException. It just takes a bit longer to publish the message.

[slang25]

Ah yeah, that doesn't help

[slang25]

I don't think adding it to the existing object makes sense, cause it relies on an exception occuring. I think this change makes most sense 👍