Fixed partials ordering and added missing responsive-embed one #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| 'scrollspy': true, | ||
| 'tab': true, | ||
| 'affix': true | ||
| "transition": true, |
There was a problem hiding this comment.
No reason to change to "". I've got the linter set to single quotes for JS.
There was a problem hiding this comment.
Np 👍 I'll revert this now, I've just standardized to double quotes, since in all the other places in this file this is the kind used.
|
Just one minor issue with quotes. |
|
@mgtitimoli Can you please verify this change works over here: https://github.com/justin808/bootstrap-sass-loader-example I won't have time to test this for a few days. However, the code looks fine. I'd like to merge this if I can get at least one person to say that that there's no issues with this change. Otherwise, I'll get this in a few days. |
|
@mgtitimoli Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue