Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong partials ordering #17

Closed
mgtitimoli opened this issue Jun 17, 2015 · 2 comments · Fixed by #18
Closed

Wrong partials ordering #17

mgtitimoli opened this issue Jun 17, 2015 · 2 comments · Fixed by #18

Comments

@mgtitimoli
Copy link
Contributor

Partials array must be ordered the same as _bootstrap.scss file present in bootstrap-sass project, since otherwise some classes override some others, causing wrong components rendering (currently glyphicon is included after forms, and this breaks the has-feedback feature).

Also I noticed, that responsive-embed partial is missing.

This PR fixes this.
@mgtitimoli mgtitimoli mentioned this issue Jun 17, 2015
Merged
@justin808
Copy link
Member

Awesome. I'll get this integrated asap!

@mgtitimoli
Copy link
Contributor Author

Great @justin808 👍, many thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed partials ordering and added missing responsive-embed one mgtitimoli/bootstrap-sass-loader
2 participants
@justin808 @mgtitimoli