Cleanup Travis and tox configs #1
Conversation
…by keeping the envlist in tox and using tox-travis to run tests on the CI. A lot more concise than that long list of excludes we had before!
flake8 and sphinx will be installed by tox when required
dev-requirements.txt
Outdated
| @@ -1,9 +1,6 @@ | |||
| -e . | |||
| flake8<3.0 | |||
| invoke>=0.11.1,<0.12 | |||
| pytest | |||
| pytest-cov | |||
| pytest-django | |||
There was a problem hiding this comment.
Do you think we need to remove the pytest packages here? Sometimes it's useful to do a quick test run on the current Python interpreter. If you still think we should remove these, then the reference to py.test should probably be removed from the Contributing > Running Tests docs.
There was a problem hiding this comment.
I think I'll add it back in. I've since tried to do things like tox -e py27 and found that it does not work as I had assumed.
There was a problem hiding this comment.
Okay, cool. Might consider doing the same with flake8, since we presumably want to encourage folks to use it. 😉
Running tox can be cumbersome, so allow developers to use flake8 and pytest outside of tox. Added django to dev-requirements.txt too otherwise pytest will error.
|
I've added flake8 and pytest back into dev-requirements.txt. I've also added django to that file because pytest is pretty useless without it. |
|
Looks good to me. Do you think any of these commits should be squashed? I'm happy to combine them into a single commit upon merge, of course... Just wasn't sure if you wanted to organize them in any particular semantic manner. |
|
I have no personal preference, so feel free to do a squash-merge ☺ |
|
Many thanks for enhancements, Matt. 👍 |
Cleaned up the Travis and tox configs, including some bits missed in my PR to django-sudo:
invoketasksdev-requirements.txtthat are no longer needed