Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 5.2.1 #413

Merged
merged 7 commits into from May 16, 2017
Merged

Backports for 5.2.1 #413

merged 7 commits into from May 16, 2017

Conversation

erayd
Copy link
Collaborator

@erayd erayd commented Apr 11, 2017

Bugfixes from 6.0.0 that can be backported to 5.2.1 without breaking backwards-compatibility.

Backported PRs

Skipped PRs

erayd and others added 3 commits April 12, 2017 08:57
Object validation attempts to use a single variable to store both the
object definition, and its properties. This causes validation to be
incomplete where "properties" is not set, but "additionalProperties" is.

This commit fixes both bugs in issue justinrainbow#353.
Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

erayd and others added 3 commits May 6, 2017 09:21
* Cast root to object

* Use function_exists to allow polyfill compatibility

* Move array->object conversion to SchemaConstraint & SchemaStorage

Fixes issue justinrainbow#408
…justinrainbow#405)

all items and add support for minItems when applying defaults
…hema bug (justinrainbow#419)

* Split "uri" format into "uri" and "uri-reference"

* Correct format for id & $ref in draft-03/04 meta-schemas

See json-schema-org/JSON-Schema-Test-Suite#177 (comment)
@erayd
Copy link
Collaborator Author

erayd commented May 16, 2017

@bighappyface Anything else you want in 5.2.1? I reckon this is about ready to ship.

@bighappyface
Copy link
Collaborator

This works for me. I will merge and roll 5.2.1.

@bighappyface bighappyface merged commit 429be23 into justinrainbow:5.x.x May 16, 2017
@erayd
Copy link
Collaborator Author

erayd commented May 16, 2017

Awesome - thanks :-).

@erayd erayd deleted the backport-521 branch May 16, 2017 21:08
@bighappyface
Copy link
Collaborator

We are ready to go: https://github.com/justinrainbow/json-schema/releases/tag/5.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants