Absolute thresholds #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason why this PR wasn't reviewed? |
|
I think it just got lost in the shuffle. I don't even manage a nagios install any more, so I can't really test it. If you want to fix the merge conflicts and test it out a bit, I'll merge it. |
|
Implemented as part of #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hacked a little to make it accept absolute threshold values. Integers/floats will still be interpreted as percentages, but 500M would be an absolute threshold.
Also, the program will not accept bogus input anymore like this:
$ ./check_mem.pl -f -C -w 99.999 -c 1monkeypoop
Argument "1monkeypoop" isn't numeric in numeric eq (==) at ./check_mem.pl line 318.
WARNING - 26.2% (2145244 kB) free!|TOTAL=8177544KB;;;; USED=6032300KB;81;8095768;; FREE=2145244KB;;;; CACHES=1807308KB;;;;
Hope this will be useful for someone.