Added isVendor(), Vendor type, organized testing, and web bundle
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sno2
commented
Sep 18, 2020
| Instead of running `isVendor()` if you need to assign a variable to a supposed `string` that is a vendor, you can just set the type of the variable to `Vendor`. Thankfully, the TypeScript compiler will make sure that your variable is one of the valid `vendors`. | ||
|
|
||
| ```ts | ||
| import { Vendor } from "https://deno.land/x/vendors/mod.ts"; |
There was a problem hiding this comment.
Should be import type { Vendor } from "https://deno.land/x/vendors/mod.ts";
sno2
commented
Sep 18, 2020
| Here is an example of what would happen if our variable isn't a valid `Vendor`: | ||
|
|
||
| ```ts | ||
| import { Vendor } from "https://deno.land/x/vendors/mod.ts"; |
There was a problem hiding this comment.
Should be import type { Vendor } from "https://deno.land/x/vendors/mod.ts";
|
Please note the comments I added because I realize that you created a new branch with my fork. The README.md should have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have already updated the
README.md&CHANGELOG.md. I think that this should probably be in a0.2.0release version after you look my changes over. Also, there is a breaking change as you usedexport defaultin version0.1.0. The testing also usesstd@0.69.0instead ofstd@0.68.0.