Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for #2751 / #2752 (pr to #2752 branch) #2

Conversation

jasonbahl
Copy link
Collaborator

@jasonbahl jasonbahl commented Mar 8, 2023

What does this implement/fix? Explain your changes.

This adds tests for the issue described in wp-graphql#2751 and fixed in wp-graphql#2752

Ideally, the tests should pass against 1.13.10, fail against 1.14.0 release branch and pass again against wp-graphql#2752 branch.

Does this close any currently open issues?

assists wp-graphql#2752 in closing wp-graphql#2751

@jasonbahl jasonbahl merged commit f7315e1 into justlevine:fix/handle-404s-in-node-resolver Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant