[EN-848] Service request chain tracking #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tjoelsson
commented
Jan 12, 2016
tjoelsson
commented
- uuid in header and access log (@wenzong)
- access log in NCSA combined format
|
@imlazyone @wanleung @agirivera please review |
|
👍 |
|
So no IP then? |
|
As I understand, getting the IP would require passing it from the client. I don't think it's worth doing that. At least not right now. |
|
ZeroMQ takes care of the address, I don't think pyzmq expose the API to get endpoint. |
|
@wanleung @agirivera please review this. it's blocking work on another ticket |
| @@ -37,6 +38,9 @@ def logger(self): | |||
|
|
|||
| class LocalContext(object): | |||
|
|
|||
There was a problem hiding this comment.
@wenzong anything to document here?
There was a problem hiding this comment.
sure, I can add some docstring
|
Only found trivial suggestion. Looks good to go 👍 |
Add docstring for LocalContext
tjoelsson
added a commit
that referenced
this pull request
Jan 15, 2016
[EN-848] Service request chain tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.