Middleware uses :path-info as well as :uri #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwmitchell
commented
Apr 14, 2014
mwmitchell
commented
- When running a Ring app in a servlet environment, :uri contains the full path of the app – which includes the servlet base path. This causes problems with route matching when your root route starts with / – because bidi currently only uses :uri. The :path-info value on the other hand, is the path, but without the servlet base path.
- This is similar to what Ring already does with the path-info fn here: https://github.com/ring-clojure/ring/blob/1d74427381b2861639033ab80007b6bbef1be508/ring-core/src/ring/util/request.clj#L54
- Added simple test
* When running a Ring app in a servlet environment, :uri contains the path of the app, but it also includes the servlet base path. This causes problems with route matching since it currently only uses :uri. * Similar to what Ring already does with the path-info fn here: https://github.com/ring-clojure/ring/blob/1d74427381b2861639033ab80007b6bbef1be508/ring-core/src/ring/util/request.clj#L54 * Added simple test
malcolmsparks
added a commit
that referenced
this pull request
Apr 16, 2014
Middleware uses :path-info as well as :uri
|
Merged. Thanks very much for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.