adds some tests around schema coercion from multipart requests #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Some tests failing on CI. |
|
Fixed one of the tests, the other involves making the DefaultPartConsumer smarter - #118 should help sort that out in a cleaner way |
|
Closing as I remember this was an interrim PR, let me know if you want to reopen. |
|
I'll have a look at this. Will need to rewrite some of the tests to work with the new yada. If they still fail I'll let you know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to highlight something I came across and what could potentially be a bug with multipart coercions. Please see the new
multipart-testI added.