Remove node-glpk dependency #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @rregue. Good idea - node-glpk seems to be dead. Last time some one came to the rescue and fixed node-glpk. Wont happen this time, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dev dependency on https://github.com/hgourvest/node-glpk. The main reason is that node-glpk does not support node version 12 and above and the current node LTS is at 14 already. It also looks like node-glpk project is not very active.
For testing, I just took the solution, instead of solving the problem with node-glpk, and hardcoded it. In addition, I have also removed the *.lp files that were being used.