Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0002 for mobility extension #119

Merged
merged 3 commits into from
Feb 4, 2023
Merged

RFC 0002 for mobility extension #119

merged 3 commits into from
Feb 4, 2023

Conversation

schlingling
Copy link
Contributor

@schlingling schlingling commented Feb 1, 2023

For my new PR, i updated the RFC-files with the feedback received from #117. This iteration of the RFC hold just really minor changes compared to #117.

As discussed with @rhazn, this should be the final PR for RFC0002 so i changed the status already to ACCEPTED.

@schlingling schlingling self-assigned this Feb 1, 2023
@rhazn
Copy link
Contributor

rhazn commented Feb 1, 2023

FYI @georg-schwarz , if you have major feedback please let us know.

Copy link
Contributor

@felix-oq felix-oq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed solely on ArrayBuffer here:

content: string | ArrayBuffer //The content of the file as a string Or maybe a byte array instead


Note that there are two remaining "tbd" in the RFC:

export interface FileSystem {
tbd
}

export interface None {
tbd
}


This question should be removed:

Not sure, how to *implement* multiple input/output of blocks (for SQLiteSink and ArchiveInterpreter)?


Otherwise I think this is good to go 👍

@schlingling
Copy link
Contributor Author

schlingling commented Feb 2, 2023

removed the tbd, commented by @felix-oq and pushed to that branch again. Changed tbd to code comment as discussed with @rhazn.

@schlingling schlingling merged commit 0bf3d11 into main Feb 4, 2023
@schlingling schlingling deleted the rfc-mobility-extension branch February 4, 2023 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2023
@schlingling
Copy link
Contributor Author

This PR is a basis for #123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants