-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapter: DataImports API and refactoring #322
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b892a30
adapter: data imports
lunedis 04dce65
adapter: fix compile issue related to typo on Getters
lunedis 39c366a
adapter: use lazy loading for data imports
lunedis 8abef34
adapter: refactor exception handly to be more springy
lunedis a97276c
adapter: simplify mappings for DataImportEndpoint
lunedis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
adapter/src/main/java/org/jvalue/ods/adapterservice/adapter/api/rest/v1/Mappings.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,22 @@ | ||
package org.jvalue.ods.adapterservice.adapter.api.rest.v1; | ||
|
||
import java.io.IOException; | ||
import java.util.Map; | ||
|
||
import org.jvalue.ods.adapterservice.adapter.model.exceptions.*; | ||
import org.springframework.http.HttpStatus; | ||
|
||
public class Mappings { | ||
public static final String IMPORT_PATH = "/preview"; | ||
public static final String RAW_IMPORT_PATH = "/preview/raw"; | ||
public static final String FORMAT_PATH = "/formats"; | ||
public static final String PROTOCOL_PATH = "/protocols"; | ||
public static final String VERSION_PATH = "/version"; | ||
|
||
public static final Map<Class, HttpStatus> ERROR_MAPPING = Map.of( | ||
ImporterParameterException.class, HttpStatus.BAD_REQUEST, | ||
InterpreterParameterException.class, HttpStatus.BAD_REQUEST, | ||
IllegalArgumentException.class, HttpStatus.BAD_REQUEST, | ||
IOException.class, HttpStatus.INTERNAL_SERVER_ERROR | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if a status code annotation directly at the exception is better?
Probably you had some thoughts on that, do you mind sharing them? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly had no clue about the way you are "supposed" to do it in Spring. Gonna have to take a look at it in detail. The solution I went for was the first one that came to mind to avoid repetition in every endpoint method.