Add option to explicitly annotate Java frames with _[j]/_[i] #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrudolph any chance you can take a look? |
|
ping? |
|
@nitsanw sorry for the silence... busy months. I'll try to have a look soon. |
nitsanw
force-pushed
the
frame-annotation
branch
from
a4d4c0d
to
67a00bf
Compare
This is done to natively support frame disambiguation. This is more accurate than than the approach taken in FlameGraph/stackcollapse-perf.pl which relies on package names. I did lump together some code cleanup here, resolving many warnings pointed out by CLion, refactoring deallocate etc. If this is too much I can split the commit into separate PRs.
nitsanw
force-pushed
the
frame-annotation
branch
from
67a00bf
to
349f1c2
Compare
|
@jrudolph well... at least now we know it builds!!! :-) |
jrudolph
approved these changes
Jan 31, 2018
| @@ -103,9 +114,9 @@ static void sig_string(jvmtiEnv *jvmti, jmethodID method, char *output, size_t n | |||
| if(entrycount > 0) lineno = lines[0].line_number; | |||
| snprintf(source_info, sizeof(source_info), "(%s:%d)", sourcefile, lineno); | |||
|
|
|||
| if (lines != NULL) (*jvmti)->Deallocate(jvmti, (unsigned char *) lines); | |||
| deallocate(jvmti, lines); | |||
| bool clean_class_names = false; | ||
| bool dotted_class_names = false; |
There was a problem hiding this comment.
Yes, makes sense to add further options. Can your document the new ones?
|
Will update the README shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a well broken down PR, sorry.
I lumped together some code cleanup/changes here:
If this is too much I can split the commit into separate PRs.
With the new options I can have PMA generate this format, which let's BCC tools generate a usable collapased stack directly:
One could argue that the right solution is a map file post processing script rather than further elaboration of the tool itself. Up for discussion.