Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error in README.md #31

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix an error in README.md #31

merged 1 commit into from
Nov 4, 2019

Conversation

singularitti
Copy link
Contributor

Running

julia> @argcheck det(a) < 0 DomainError()
ERROR: MethodError: no method matching DomainError()
Closest candidates are:
  DomainError(::Any) at boot.jl:258
  DomainError(::Any, ::Any) at boot.jl:259
Stacktrace:
 [1] top-level scope at /Users/qz/.julia/packages/ArgCheck/xX4DA/src/checks.jl:165

will throw a MethodError, because DomainError cannot have empty field. It should be either

julia> @argcheck det(a) < 0 DomainError
ERROR: DomainError with det(a) < 0 must hold. Got
det(a) => 0.07470301636255529:

or DomainError with some msg:

julia> @argcheck det(a) < 0 DomainError("error")
ERROR: DomainError with error:

Stacktrace:
 [1] top-level scope at /Users/qz/.julia/packages/ArgCheck/xX4DA/src/checks.jl:165

@jw3126 jw3126 merged commit 644b932 into jw3126:master Nov 4, 2019
@jw3126
Copy link
Owner

jw3126 commented Nov 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants