cq_osgi_config refactoring #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 25, 2016 21:18
…dundant debug lines removed
…o move factories to separate provider, but let's leave this for now as is
…ctor them further
…osgi_bundle and cq_osgi_component are involved into this procedure. Additionally all healthchecks related params were gathered in a single attr accessor
…o possible presence of append flag
added 18 commits
November 4, 2016 02:24
…been extracted to individual module, OSGi bundles are verified after cq_package and cq_osgi_bundle, OSGi components after cq_osgi_config and cq_osgi_component
… of factory OSGi configs
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #21
TODO list:
forceattribute is completely ignored, please restore desired behaviour:deleteaction will work (I hope so) for regular configs, but won't for factory ones. Please get this implemented at the earliest possibility