Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with modern software #61

Closed
Stratadox opened this issue May 17, 2018 · 4 comments
Closed

Incompatible with modern software #61

Stratadox opened this issue May 17, 2018 · 4 comments

Comments

@Stratadox
Copy link

Any software package with a dev dependency on PhpUnit 7+ is incompatible with jwage/purl:

jwage/purl dev-master requires phpunit/phpunit ^4.8|^5.5|^6.5

Conflicts with:

Installation request for phpunit/phpunit ~7.0

The problem is probably caused by phpunit being in require rather than require -dev.

@jwage
Copy link
Owner

jwage commented May 17, 2018

@peter279k could you look at this by chance?

@peter279k
Copy link
Contributor

It seems that the package dependency problem.
@jwage. How about setting the jwage/purl dev-master requires phpunit/phpunit ^4.8|^5.5|^6.5|^7.0 in composer.json?

@jwage
Copy link
Owner

jwage commented May 17, 2018

Yes, that makes sense. Move it to require-dev and allow all the versions of phpunit that our suite will work with.

peter279k added a commit to peter279k/purl that referenced this issue May 17, 2018
@peter279k peter279k mentioned this issue May 17, 2018
peter279k added a commit to peter279k/purl that referenced this issue May 17, 2018
jwage added a commit that referenced this issue May 17, 2018
@jwage jwage closed this as completed May 17, 2018
@jwage
Copy link
Owner

jwage commented May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants