Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying a custom onClose callback stops methods.close being called #28

Closed
jwarby opened this issue Aug 12, 2014 · 0 comments
Closed

Specifying a custom onClose callback stops methods.close being called #28

jwarby opened this issue Aug 12, 2014 · 0 comments
Assignees
@jwarby
Labels
bug in progress
Milestone
Version 2

Comments

@jwarby
Copy link
Owner

jwarby commented Aug 12, 2014

If you specify a callback for the close event, methods.close does not get called. This results in the following:

  • custom onClose callback does fire
  • the tour does not get hidden
@jwarby jwarby added this to the Version 2 milestone Aug 12, 2014
@jwarby jwarby added bug and removed ready labels Aug 12, 2014
@jwarby jwarby self-assigned this Aug 12, 2014
@jwarby jwarby closed this as completed in e639d04 Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwarby jwarby

Labels
bug in progress
Projects
None yet
Milestone
Version 2
Development

No branches or pull requests
1 participant
@jwarby