Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Avoid node crash during compilation #62

Merged
merged 1 commit into from
Aug 10, 2012
Merged

Avoid node crash during compilation #62

merged 1 commit into from
Aug 10, 2012

Conversation

rricard
Copy link
Contributor

@rricard rricard commented Aug 9, 2012

In a very specific case (rjs_driver.js placed in a directory containing space chars in his name), node crashed because it couldn't find the file.
The fix is really simple but makes the compilation succeed !

This Pull Request is solving a problem seen in Issue #61.

In a very specific case (rjs_driver.js placed in a directory containing space chars in his name), node crashed because it couldn't find the file.
The fix is really simple but makes the compilation succeed !
jwhitley added a commit that referenced this pull request Aug 10, 2012
Avoid node crash during compilation. Fixes #61.
@jwhitley jwhitley merged commit 8a437fe into jwhitley:master Aug 10, 2012
@jwhitley
Copy link
Owner

I'm way overdue for an update release for requirejs 2.0.x, so I'll work on getting this out in an official release along with the requirejs update ASAP.

@rricard
Copy link
Contributor Author

rricard commented Aug 10, 2012

That's fine for me, I wanted to implement lists of paths (to mix up CDNs and local fallbacks for the same js file) ...
It looks like that :

paths:
  zepto:
    - 'http://cdnjs.cloudflare.com/ajax/libs/zepto/1.0rc1/zepto.min'
    - zepto
  jquery:
    - 'http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min'
    - jquery

But it currently fails because the CDN detection doesn't investigate into arrays. I can open an issue for that but if I can find that by myself, I'll directly open an another pull request before you push the gem.

Just thought about it : it'll need tests and stuff ... I'll open an issue !

@jwhitley
Copy link
Owner

@ricardrobin Go ahead and open an issue if you like. You can transform it into a PR using defunkt's hub tool. Then you can just do:

git pull-request -i <number>

Where <number> is an existing issue number. It'll append the code to that issue and promote it to a PR.

(Note: using hub as a git wrapper like that requires that you set up the aliasing described in the README.)

@rricard
Copy link
Contributor Author

rricard commented Aug 10, 2012

Nice tip ! Thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants