Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct prefix keys after use-package-autoload-keymap #686

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

justbur
Copy link
Contributor

@justbur justbur commented Jun 4, 2018

By adding events of the form (cons t event) to unread-command-events, Emacs
correctly updates this-command-keys for the subsequent use of the prefix.

Before this change, packages like my which-key were not getting the correct
prefix after use-package-autoload-keymap loaded the relevant package.

See justbur/emacs-which-key#192

By adding events of the form (cons t event) to unread-command-events, Emacs
correctly updates this-command-keys for the subsequent use of the prefix.

Before this change, packages like my which-key were not getting the correct
prefix after use-package-autoload-keymap loaded the relevant package.

See justbur/emacs-which-key#192
@mambolevis
Copy link

Hi, I'am waiting and ready for making tests if required.

@andyleejordan
Copy link
Contributor

I tested and this fixed the issue for me too. I can now use :bind-keymap ("C-c &" . yas-keymap) and the which-key guide is correctly filled in with the yas-keymap after the package is loaded (and previously it just showed the guide for C-c).

@andyleejordan
Copy link
Contributor

@jwiegley This PR has been working great, just FYI 😄

@jwiegley jwiegley merged commit 3fb8f39 into jwiegley:master Jul 15, 2018
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Nov 24, 2022
Correct prefix keys after use-package-autoload-keymap
GitHub-reference: jwiegley/use-package#686
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Nov 29, 2022
Correct prefix keys after use-package-autoload-keymap
GitHub-reference: jwiegley/use-package#686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants