Skip to content

Commit

Permalink
Show mute button on mobile (#1490)
Browse files Browse the repository at this point in the history
* Show volume toggle on mobile
JW7-2956
  • Loading branch information
hussam-i-am authored and egreaves committed Oct 18, 2016
1 parent f72f947 commit e5a2941
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 5 deletions.
Binary file modified assets/fonts/jw-icons.eot 100755 → 100644
Binary file not shown.
2 changes: 1 addition & 1 deletion assets/fonts/jw-icons.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/fonts/jw-icons.ttf 100755 → 100644
Binary file not shown.
Binary file modified assets/fonts/jw-icons.woff 100755 → 100644
Binary file not shown.
5 changes: 3 additions & 2 deletions assets/fonts/svg/jw7-icomoon-icon-setup.json
Expand Up @@ -129,7 +129,7 @@
"width": 84,
"height": 100
},
"iconsHash": 289144099
"iconsHash": 1284002988
},
"height": 1024,
"prevSize": 32,
Expand Down Expand Up @@ -283,7 +283,8 @@
},
{
"paths": [
"M64 652.8v-275.2h204.8l275.2-204.8v684.8l-275.2-204.8h-204.8z"
"M64 652.8v-275.2h204.8l275.2-204.8v684.8l-275.2-204.8h-204.8z",
"M974.9 387.7l-46.8-46.7-124.2 124.3-123.2-124.3-47.8 46.7 124.2 124.3-124.2 124.3 47.8 46.7 123.2-124.3 124.2 124.3 46.8-46.7-123.2-124.3z"
],
"width": 1216,
"isMulticolor2": false,
Expand Down
1 change: 1 addition & 0 deletions assets/fonts/svg/volume.jw-off.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions src/css/flags/touch.less
Expand Up @@ -24,6 +24,12 @@
}
}

.jw-controlbar {
.jw-icon-volume {
display: inline-block;
}
}

.jw-display-icon-container {
pointer-events: none;
}
Expand Down
4 changes: 2 additions & 2 deletions src/js/view/controlbar.js
Expand Up @@ -94,12 +94,12 @@ define([
var vol = this._localization.volume;
var rewind = this._localization.rewind;

// Do not initialize volume sliders on mobile.
// Do not initialize volume slider or tooltip on mobile
if(!this._isMobile){
muteButton = button('jw-icon-volume', this._api.setMute, vol);
volumeSlider = new Slider('jw-slider-volume', 'horizontal');//, vol);
volumeTooltip = new VolumeTooltip(this._model, 'jw-icon-volume', vol);
}
muteButton = button('jw-icon-volume', this._api.setMute, vol);

this.elements = {
alt: text('jw-text-alt', 'status'),
Expand Down

0 comments on commit e5a2941

Please sign in to comment.