Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed Seek in HTML5 provider #918

Closed
robwalch opened this issue Nov 24, 2015 · 2 comments
Closed

Delayed Seek in HTML5 provider #918

robwalch opened this issue Nov 24, 2015 · 2 comments

Comments

@robwalch
Copy link
Contributor

Handling of seek commands before 'timeupdate' or 'canplay' events by setting a _delayedSeek time results in a lot of complexity in html5.js. This was made worse recently by having to add a video tag play() for Firefox to trigger the 'canplay' event we require after changing video src (#916).

We need to continue to simplify html5.js by removing individual properties or flags that introduce functionality in the provider that is meant to store desired state.

egreaves added a commit that referenced this issue Dec 7, 2015
* master:
  Fix for delayed seek in DVR mode
  Cleaned up module export
  Captions ajax call is a mixed request
  Check seekable range in seek
  Handle androidHLS duration issues
  added safari launcher
  Changed the order so that mute is set after volume is set so that it correctly overrides audio values
  Ajax util refactor and tests
  First step in DVR duration
  Improve seeking to midpoint after load #918
@coladeu
Copy link

coladeu commented Sep 3, 2017

Can you do a caption delay control feature? To control the subtitle delay if is out of sync? Or can you tell me with what line of the code from jwplayer.js do i have to play in order to get an effect on caption delay?

@johnBartos
Copy link
Contributor

@coladeu There is no feature for captions delay. When the HTML5 provider is active we're using the browser's native playback capabilities, and this includes native captioning. We can't modify the times of native captions because they exist outside of the player. When rendering non-natively, I suppose you could modify the start time immediately after parsing here (https://github.com/jwplayer/jwplayer/blob/master/src/js/controller/tracks-loader.js#L68) or when parsing, here (https://github.com/jwplayer/jwplayer/blob/master/src/js/parsers/captions/vttparser.js#L234). I'm not sure how well or if this will work at all, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants