Merge Idle Button A/B Test from v8.2.x into master #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JW8-1268
Variant Idle Display Icons
|
test this please |
robwalch
approved these changes
Mar 21, 2018
|
@egreaves @hghazzi @johnBartos @karimJWP @DanFerrer I think it's important we don't Squash and Merge PRs like this. The branch history should be clear between master and patch branches, and shared code should be from the same commits (a squashed commit would be a different commit, and the rebasing should have been done in the original branch or when first merged into v8.2.x). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Merge in the latest changes in v8.2.x into master to keep it up to sync
Why is this Pull Request needed?
So that the Idle Button A/B Test is part of master
Are there any points in the code the reviewer needs to double check?
Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
JW8-1268