Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse HTML for titles and localization #3249

Merged
merged 1 commit into from Jan 23, 2019

Conversation

robwalch
Copy link
Contributor

@robwalch robwalch commented Jan 14, 2019

This PR will...

Address handling of HTML and HTML encoded characters in content titles and localization options.

Why is this Pull Request needed?

The player supports display of html characters in the title and description on the idle screen, but not in other parts of the player. These include the right click info overlay, related overlays, and localizations options where html encoded characters may be included in the translations.

Are there any Pull Requests open in other repos which need to be merged with this?

https://github.com/jwplayer/jwplayer-plugin-related/pull/371

Addresses Issue(s):

JW8-2605

@johnBartos
Copy link
Contributor

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@jwplayer-robot
Copy link

⚠️ MULTI Build for commit 048780c is unstable (UNSTABLE).
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests SUCCESS
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@jwplayer-robot
Copy link

⚠️ MULTI Build for commit 048780c is unstable (FAILURE).
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests UNSTABLE
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests FAILURE
🍆 Manual Tests
📺 Views

@robwalch robwalch added this to the 8.7.5 milestone Jan 23, 2019
@robwalch
Copy link
Contributor Author

@DanFerrer bumping these to 8.7.5

@jwplayer-robot
Copy link

MULTI Build for commit 048780c passed.
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests SUCCESS
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@DanFerrer DanFerrer changed the base branch from master to v8.7.x January 23, 2019 16:45
@DanFerrer DanFerrer changed the base branch from v8.7.x to master January 23, 2019 16:48
@DanFerrer DanFerrer merged commit 4420dcf into master Jan 23, 2019
@jwplayer-robot
Copy link

MULTI Build for commit 048780c did not complete (${PHASE_RESULT}).
🏗️ jwplayer build ${JW7_OPENSOURCE_BUILD_RESULT}
🏗️ jwplayer browserstack tests ${JW7_OPENSOURCE_UNIT_TESTS_BUILD_RESULT}
🏗️ jwplayer-commercial build ${JW7_COMMERCIAL_BUILD_RESULT}
🏗️ jwplayer-commercial browserstack tests ${JW7_COMMERCIAL_UNIT_TESTS_BUILD_RESULT}
🥒 Automated Tests ${JW7_COMMERCIAL_CUCUMBER_BUILD_RESULT}
🍆 Manual Tests
📺 Views

@robwalch robwalch deleted the feature/html-parse-titles-and-tooltips branch January 24, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants