[JW8-2607] Keep controls visible is activated via keyboard #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interaction JW8-2607
Generated by 🚫 dangerJS |
johnBartos
reviewed
Jan 23, 2019
DanFerrer
changed the title
johnBartos
approved these changes
Jan 23, 2019
karimMourra
reviewed
Jan 24, 2019
| @@ -71,10 +70,20 @@ export default class Controls { | |||
| this.activeTimeout = setTimeout(this.userInactiveTimeout, remainingTime); | |||
| return; | |||
| } | |||
| if (this.playerContainer.querySelector('.jw-tab-focus')) { | |||
There was a problem hiding this comment.
@DanFerrer why do we need this ? We already set the activeTimeout to 0 when tabbing inside the player
jwplayer/src/js/view/controls/controls.js
Line 325 in 8bef82f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Only call
this.userInactiveinside theuserInactiveTimeoutif players controls weren't shown through a keyboard interaction.Why is this Pull Request needed?
We want to keep the controls visible when a user is currently focused on the player for better accessibility.
Are there any points in the code the reviewer needs to double check?
Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
JW8-2607