Do not apply new max-width to floating player #3310
Conversation
Generated by 🚫 dangerJS |
| @@ -901,9 +901,7 @@ function View(_api, _model) { | |||
| const width = _model.get('width'); | |||
| const height = _model.get('height'); | |||
| const styles = getPlayerSizeStyles(width); | |||
| if (isNumber(width)) { | |||
There was a problem hiding this comment.
@DanFerrer does this revert some of your aspect ratio work from earlier? are there any considerations for the mobile case?
There was a problem hiding this comment.
@pajong it seems to me like the problem is a missing size constraint. If it appears too big on desktop, i would say we should enforce a specific width or a smaller max-width, instead of removing max-width
There was a problem hiding this comment.
@jnatalzia This shouldn't break anything I'm aware of. We already have size constraints for max-width in floatingplayer.less at 400pxwith the exception of mobile portrait where we set the max-width to none
…g-drag-exclude-ads * origin/master: v8.8.0-beta.1 Do not apply new max-width to floating player (#3310) JW8-5615 Normalize the disabling of floating in the config Move _pauseWhenNotViewable() outside of _checkPauseWhenViewable(), addressed Jong's fb Changed name of function, addressed Joe's feedback Handle VAST ads setting player to idle
This PR will...
Not apply new max-width to the floating player
Why is this Pull Request needed?
Applying new max-width made the floating player larger on desktop, which we did not want
Are there any points in the code the reviewer needs to double check?
It looks like the code was added for mobile - I did a quick run on mobile and it looked fine removing this, but if there were some specific cases, please let me know
Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
JW8-###