Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JW8-10140] Don't update size on aspect ratio change when floating #3464

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@robwalch
Copy link
Member

commented Aug 9, 2019

Why is this Pull Request needed?

To prevent the player from being resized when floating. This could lead to a loop where the player floats, resizes, goes in to view, stop floating, resizes, goes out of view and repeats.

Addresses Issue(s):

JW8-10140

@robwalch robwalch added this to the 8.10.0 milestone Aug 9, 2019

@robwalch robwalch requested review from johnBartos and waxidiotic Aug 9, 2019

@johnBartos

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

Copy link

commented Aug 9, 2019

⚠️ MULTI Build for commit 82f7e9d is unstable (FAILURE).
🏗 jwplayer build SUCCESS
🏗 jwplayer unit tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial unit tests SUCCESS
🥒.js Allure Report FAILURE
🥒 Allure Report UNSTABLE
🍆 Manual Tests
📺 Views

@waxidiotic
Copy link
Member

left a comment

Bunch of test failures but they all appear unrelated and we're having issues with the tests.

@waxidiotic waxidiotic merged commit e27d13c into master Aug 9, 2019

3 of 4 checks passed

jw7-pr-multi-opensource Build finished.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@waxidiotic waxidiotic deleted the bugfix/floating-resize branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.