[JW8-10913] Add adWarning event #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JW8-10913
This comment has been minimized.
This comment has been minimized.
vseventer
approved these changes
Feb 19, 2020
|
test this please |
pajong
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JW8-10913
This PR will...
adWarningevent to the list of events the player handlesWhy is this Pull Request needed?
adWarningevent to the VAST plugin.Are there any points in the code the reviewer needs to double check?
n/a
Are there any Pull Requests open in other repos which need to be merged with this?
https://github.com/jwplayer/jwplayer-commercial/pull/7443
https://github.com/jwplayer/jwplayer-ads-vast/pull/638
Addresses Issue(s):
JW8-10913
Checklist