Make androidhls not show buffering #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //when androidhls is set to true, allow HLS playback on Android 4.1 and up | ||
| if (source.androidhls) { | ||
| var isAndroidNative = utils.isAndroidNative; | ||
| if (isAndroidNative(2) || isAndroidNative(3) || isAndroidNative('4.0')) { |
There was a problem hiding this comment.
these can be cached up top, look for _isAndroid, _isSafari, etc
robwalch
force-pushed
the
bugfix/android-chrome-hls-buffering
branch
from
47ded36
to
880f4f7
Compare
robwalch
added a commit
that referenced
this pull request
Jul 6, 2015
…ring Make androidhls not show buffering [Delivers #98233336]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
androidhls never updates the current time so it will always fall into the stall state. For now we will assume android hls streaming will send work well.
[Delivers #98233336]