Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending remote extension #127

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Extending remote extension #127

merged 4 commits into from
Jul 20, 2020

Conversation

jamowei
Copy link
Collaborator

@jamowei jamowei commented Jul 20, 2020

Added new append() function and added a new test which uses crudcrud.com

jwstegemann
jwstegemann previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Owner

@jwstegemann jwstegemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThumbUp!

@jamowei jamowei requested a review from jwstegemann July 20, 2020 18:49
jwstegemann
jwstegemann approved these changes Jul 20, 2020
View reviewed changes
core/src/jsMain/kotlin/dev/fritz2/remote/remote.kt
@@ -97,60 +97,71 @@ open class Request(
/**
* issues a get request returning a flow of it's response
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jwstegemann jwstegemann merged commit 8bc9252 into master Jul 20, 2020
@jamowei jamowei added this to the 0.7 milestone Jul 23, 2020
@jamowei jamowei deleted the jamowei/addedCrudCrudTests branch July 30, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwstegemann jwstegemann jwstegemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jamowei @jwstegemann