Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Numeric values during encoding #327

Merged
merged 1 commit into from Sep 1, 2020
Merged

Allow Numeric values during encoding #327

merged 1 commit into from Sep 1, 2020

Conversation

@fanfilmu
Copy link
Contributor

@fanfilmu fanfilmu commented Jul 26, 2019

Hi!

According to this #134 and the sources linked there, exp, nbf and iat claims are NumericDates, not integers.

This PR allows numeric values for those claims during token creation.

I'm not sure where the validator was added, but I discovered the issue while upgrading from 1.x to 2.x - in 1.x float values were allowed.

@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Jul 26, 2019

Hello, @fanfilmu! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@excpt excpt self-requested a review Jul 7, 2020
@excpt excpt added this to the Version 2.3.0 milestone Jul 7, 2020
@excpt
excpt approved these changes Sep 1, 2020
@excpt excpt merged commit 9251b31 into jwt:master Sep 1, 2020
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sourcelevel-bot
sourcelevel SourceLevel did not find any new or fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants