Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document why changing some characters in a Base64-encoded string does not invalidate signatures #518

Closed
lhazlewood opened this issue Oct 14, 2019 · 0 comments · Fixed by #560
Closed

Document why changing some characters in a Base64-encoded string does not invalidate signatures #518

lhazlewood opened this issue Oct 14, 2019 · 0 comments · Fixed by #560
Labels
enhancement
Milestone
0.11.0

Comments

@lhazlewood
Copy link
Contributor

lhazlewood commented Oct 14, 2019 •
edited
Loading

Add a section to the Readme why this doesn't invalidate signature calculation and is not a flaw in the library. See #211 #269 #324 and others.

Also:

#520 (comment)

https://stackoverflow.com/questions/29941270/why-do-base64-decode-produce-same-byte-array-for-different-strings

https://stackoverflow.com/questions/33663113/multiple-strings-base64-decoded-to-same-byte-array?noredirect=1&lq=1
@lhazlewood lhazlewood added this to the 0.11.0 milestone Oct 14, 2019
@lhazlewood lhazlewood mentioned this issue Oct 21, 2019
Closed
@lhazlewood lhazlewood changed the title Document why changing some characters in a Base64-encoded key string do not invalidate signatures Document why changing some characters in a Base64-encoded string do not invalidate signatures Oct 21, 2019
@lhazlewood lhazlewood changed the title Document why changing some characters in a Base64-encoded string do not invalidate signatures Document why changing some characters in a Base64-encoded string does not invalidate signatures Oct 21, 2019
lhazlewood added a commit that referenced this issue Feb 5, 2020
@lhazlewood
Documented why changing Base64 sometimes does not invalid signature c…
c9af214 
…hecks. Resolves #518
@lhazlewood lhazlewood mentioned this issue Feb 5, 2020
Merged
lhazlewood added a commit that referenced this issue Feb 5, 2020
@lhazlewood
Documented why changing Base64 sometimes does not invalid signature c…
e042507 
…hecks. Resolves #518
lhazlewood added a commit that referenced this issue Feb 5, 2020
@lhazlewood
Documented why changing Base64 sometimes does not invalid signature c…
edff095 
…hecks. Resolves #518
lhazlewood added a commit that referenced this issue Feb 5, 2020
@lhazlewood
Documented why changing Base64 sometimes does not invalid signature c…
ab669cb 
…hecks. Resolves #518
lhazlewood added a commit that referenced this issue Feb 5, 2020
@lhazlewood
Documented why changing Base64 sometimes does not invalid signature c…
5481248 
…hecks. Resolves #518 (#560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Documented why changing Base64 sometimes does not invalid signature checks. jwtk/jjwt
1 participant
@lhazlewood