-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JwtParser parse
method name changes
#834
Milestone
Comments
lhazlewood
changed the title
Parse method name changes
JwtParser Sep 16, 2023
parse
method name changes
lhazlewood
added a commit
that referenced
this issue
Sep 30, 2023
- Deprecated JwtParser parseContentJwt, parseClaimsJwt, parseContentJws and parseClaimsJws in favor of parseUnprotectedContent, parseUnprotectedClaims, parseSignedContent, and parseSignedClaims - Renamed the not-yet-released JwtParser parseContentJwe and parseClaimsJwe to parseEncryptedContent and parseEncryptedClaims - Renamed the not-yet-released JwtParser overloaded unencoded payload parseContentJws and parseClaimsJws methods to parseSignedContent and parseSignedClaims Still need to refactor the JwtHandler and JwtHandlerAdapter concepts, probably using the visitor pattern with a new JwtVisitor interface
lhazlewood
added a commit
that referenced
this issue
Oct 3, 2023
lhazlewood
added a commit
that referenced
this issue
Oct 3, 2023
* Closes #834 - Deprecated JwtParser parseContentJwt, parseClaimsJwt, parseContentJws and parseClaimsJws in favor of parseUnprotectedContent, parseUnprotectedClaims, parseSignedContent, and parseSignedClaims - Renamed the not-yet-released JwtParser parseContentJwe and parseClaimsJwe to parseEncryptedContent and parseEncryptedClaims - Renamed the not-yet-released JwtParser overloaded unencoded payload parseContentJws and parseClaimsJws methods to parseSignedContent and parseSignedClaims - Deprecated JwtHandler and JwtHandlerAdapter in favor of JwtVisitor and SupportedJwtVisitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Creating this issue per the discussion in #658
Since parsing unprotected JWTs is not possible by default (RFCs mandate disabling this behavior by default), and can only be supported by configuring the
JwtParserBuilder
inmaster
(via theenableUnsecured()
builder method), unexpectedparse
method invocations are still protected/secure by default.To that end, this issue represents a name change purely in the name of convenience and self-documentation. It is to change the various
parse
* methods fromparseClaimsJws
,parseClaimsJwt
, etc (which might not be easy to distinguish visually and easily chosen incorrectly) to something more readable/explicit and less likely to be chosen mistakenly. For example:The text was updated successfully, but these errors were encountered: