CIO-312 Remove similar block

[sog01]

Fixes #312

Isolate common style

Description

Isolate common style at 3 exported const which are statusBarContainer, statusBar and messageCenter

Motivation and Context

To dry up code, Fixes #312.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.

[joshuabot]

	Warnings
⚠️	Changes to app files were detected, did you forget a CHANGELOG entry? You can find it at CHANGELOG.md

Generated by 🚫 dangerJS

[sog01]

Please review @jwu910, can I just remove props on similar block ?

[jwu910]

Just started reviewing :)

Sent from GH.

[jwu910]

With the comment above we can keep this as

const blessedObject = blessed.element({
	...baseTheme,
	bottom: 2,
	height: 5,
});

Let me know what you think! Thanks!

[sog01]

Actually, I though that bottom and height also noticed as a similar, so I localize using a function which passing bottom and height as a params. Since they have different value.

That should be simply if only using an object. Thanks for suggestion @jwu910 !. I'll fix then.

[jwu910]

That makes sense! Don't worry, I just think that the flow of understanding the code for future maintainability may be more straight forward if we just use a plain object for now.

[jwu910]

By the way @sog01 my development branch was just updated, be sure to get the changes!

[sog01]

Sure @jwu910, I'll be careful

[sog01]

Please check again @jwu910

[jwu910]

Just started reviewing :)

Sent from GH.

[jwu910]

lgtm

[jwu910]

@sog01 One last thing,

Can you add a changelog entry for your fix?

[sog01]

@jwu910 sure, may I also change date into today ? Since this changed happen right now.

[jwu910]

@sog01 You don't need to include a date on the changelog entry. Just the summary of work, you can place it under the "Unreleased" header. You can look at the other changelog entires for reference.

[sog01]

Okay please check again @jwu910

[jwu910]

@sog01 Your entry in the Changelog should fall under Unreleased because this issue is not yet released.

[sog01]

Sorry my bad @jwu910 🙏, It should be okay right now :)